Improves determine_block_hash method of AsyncSubtensor#3087
Merged
Improves determine_block_hash method of AsyncSubtensor#3087
determine_block_hash method of AsyncSubtensor#3087Conversation
basfroman
requested changes
Oct 7, 2025
basfroman
approved these changes
Oct 7, 2025
Merged
basfroman
added a commit
that referenced
this pull request
Oct 14, 2025
Improves `determine_block_hash` method of `AsyncSubtensor`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #3083 raised the issue of
block_hashandblockbeing passed todetermine_block_hashwhen supplying ablocktoget_neuron_for_pubkey_and_subnet.The short fix for this was #3084, but improving on this is better.
Because
AsyncSubtensor.get_block_hashis cached, there's really no performance loss in checking the block hash if both the block and block_hash are supplied todetermine_block_hash.With this PR, if both a block and block_hash are passed to
determine_block_hash, it will verify that the actual block hash maps to the corresponding supplied block hash for the given block, raising a ValueError if not.