Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(form): [form] fix content not aligned when display only close #1698 #1805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 2, 2024
Merged

fix(form): [form] fix content not aligned when display only close #1698 #1805

merged 1 commit into from
Aug 2, 2024

Conversation

gimmyhehe
Copy link
Member

@gimmyhehe gimmyhehe commented Jul 31, 2024 •
edited by coderabbitai bot
Loading

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • New Features

    • Enhanced styling for form items, improving the visual presentation of numeric fields and checkbox groups in read-only states.
    • Introduced a new CSS variable for adjusting the top margin of numeric form items, promoting better layout consistency.

  • Bug Fixes

    • Resolved alignment issues in numeric fields and checkbox groups to enhance usability and responsiveness.

@gimmyhehe gimmyhehe added the bug Something isn't working label Jul 31, 2024
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jul 31, 2024 •
edited
Loading

Walkthrough

The recent changes enhance the styling of form items, particularly focusing on numeric fields and checkbox groups. New CSS classes and variables have been introduced to improve layout consistency and visual presentation, especially for read-only numeric inputs and checkbox groups with specific display conditions. These updates aim to refine the user interface, ensuring better usability without altering core functionality.

Changes

File Path Change Summary
packages/theme/src/form-item/index.less Introduced .is-display-only class for numeric fields to adjust vertical alignment; modified .checkbox-group for better layout responsiveness.
packages/theme/src/form-item/vars.less Added CSS variable --ti-form-item-numeric-display-margin-top: -2px for margin adjustments in read-only numeric items.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant NumericField
    participant CheckboxGroup

    User->>NumericField: View Numeric Input
    NumericField->>User: Show Numeric Value (read-only)
    User->>CheckboxGroup: View Checkbox Options
    CheckboxGroup->>User: Display Options (adjusted layout)
Loading

Poem

🐇 In the garden of forms, a change we see,
Numeric fields dance, so happy and free!
Checkboxes align, with style now refined,
A whimsical layout, where all are designed.
With margins adjusted, oh what a delight,
Usability blooms, in the soft morning light! 🌼✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot]
coderabbitai bot reviewed Jul 31, 2024
View reviewed changes
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 04bf0ae and 7ad05f1.

Files selected for processing (2)
  • packages/theme/src/form-item/index.less (2 hunks)
  • packages/theme/src/form-item/vars.less (1 hunks)
Additional comments not posted (4)
packages/theme/src/form-item/vars.less (1)

68-69: Addition of new CSS variable for numeric display margin.

The new CSS variable --ti-form-item-numeric-display-margin-top set to -2px is a good addition to adjust the top margin of numeric form items in a read-only state. This change enhances the styling and layout consistency.

packages/theme/src/form-item/index.less (3)

151-153: Improvement in vertical alignment for display-only numeric elements.

The .is-display-only class modifies the vertical alignment of numeric elements to middle, improving the visual presentation of numeric fields in a read-only state.

156-158: Addition of margin-top for display-only numeric elements.

The .numeric.is-display-only class introduces a margin-top property to address horizontal alignment issues, ensuring better layout consistency for numeric fields in a read-only state.

196-200: Enhancement of layout flexibility for checkbox groups.

The .checkbox-group class introduces new style rules for labels marked with .is-group-display-only, enhancing the layout flexibility and responsiveness of checkbox groups.

@zzcr zzcr merged commit 6bee156 into opentiny:dev Aug 2, 2024
3 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@zzcr zzcr zzcr approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gimmyhehe @zzcr