Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@zzcr
Copy link
Member

@zzcr zzcr commented Jan 13, 2025

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

Based on the comprehensive summary, here are the concise release notes:

  • New Features

    • Added support for Nuxt module
    • Enhanced mobile dependencies
    • Improved components like dropdowns and navigation menus
  • Bug Fixes

    • Resolved issues in crypto, SSR, and Nuxt plugins
    • Fixed mobile-specific problems in various components
    • Addressed grid and time picker interaction challenges
  • Documentation

    • Updated installation guides
    • Streamlined component documentation
  • Chores

    • Updated dependencies
    • Migrated Playwright test configurations
    • Adjusted package versioning to 3.21.1
  • Refactors

    • Simplified element selection in test scripts
    • Reorganized dependency management
    • Removed Rich Text Editor components

zzcr and others added 10 commits January 9, 2025 14:10
* docs: change docs content

* docs: fix demo-list children miss width style
…sEdit is set true (#2770)

* fix(grid): [grid] fix repeated trigger cell active when boardConfig.isEdit is set true

* fix(grid): [grid] fix value to be set null when keyboard enter edit
* fix(theme-tool): add theme-tool.d.ts for tinyOldTheme vars

* fix(theme): update version
* test: update @playwright/test to 1.49.x

* test(grid): fix grid e2e test case

* test(grid): fix grid e2e test case
@coderabbitai
Copy link

coderabbitai bot commented Jan 13, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request encompasses a comprehensive set of changes across multiple files and components, primarily focusing on simplifying code structure, removing deprecated components, and updating dependency management. The modifications span GitHub Actions workflows, test configurations, package dependencies, and component implementations. Key areas of change include the removal of the Rich Text Editor component, updates to grid-related utilities, and standardization of dependency versioning across various packages.

Changes

File/Group Change Summary
.github/workflows/auto-all-publish.yml Removed publishVersion output variable and simplified build commands
examples/sites/package.json Added/reinstated dependencies like @docsearch/* and modified @playwright/test to use catalog reference
examples/sites/demos/pc/app/grid/custom/* Introduced custom locator in multiple test files to streamline element selection
examples/sites/demos/pc/app/rich-text-editor/* Completely removed Rich Text Editor related files and documentation
internals/cli/src/shared/config.ts Modified external dependency handling, removing Rich Text Editor references
packages/vue/package.json Updated version to 3.21.1 and removed @opentiny/vue-rich-text-editor dependency

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Workflow as GitHub Actions
    participant Package as Package Management
    
    Dev->>Workflow: Trigger build
    Workflow->>Workflow: Remove publishVersion output
    Workflow->>Package: Resolve dependencies using catalog
    Package-->>Workflow: Return resolved dependencies
    Workflow->>Workflow: Execute simplified build steps
Loading

Possibly related PRs

Suggested labels

chore

Suggested reviewers

  • kagol

Poem

🐰 A Rabbit's Ode to Code Cleanup 🧹

Workflows trimmed, dependencies neat,
Rich Text Editor's final retreat
Locators dance with graceful ease
Simplifying code like autumn leaves
CodeRabbit hops, refactoring done! 🚀


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 83b8346 and 8ae0fdf.

📒 Files selected for processing (67)
  • .github/workflows/auto-all-publish.yml (1 hunks)
  • examples/docs/package.json (1 hunks)
  • examples/sites/demos/pc/app/grid/custom/column-fixed.spec.js (1 hunks)
  • examples/sites/demos/pc/app/grid/custom/column-sort.spec.js (1 hunks)
  • examples/sites/demos/pc/app/grid/custom/column-visible-hidden.spec.js (1 hunks)
  • examples/sites/demos/pc/app/grid/custom/multiple-column-sort.spec.js (1 hunks)
  • examples/sites/demos/pc/app/grid/custom/ordercolumn-local.spec.js (1 hunks)
  • examples/sites/demos/pc/app/grid/custom/reset-resizable.spec.js (1 hunks)
  • examples/sites/demos/pc/app/grid/edit/custom-editing.spec.js (1 hunks)
  • examples/sites/demos/pc/app/grid/edit/editing.spec.js (1 hunks)
  • examples/sites/demos/pc/app/grid/edit/has-row-change.spec.js (1 hunks)
  • examples/sites/demos/pc/app/grid/edit/revert-data.spec.js (1 hunks)
  • examples/sites/demos/pc/app/grid/edit/status-of-editing.spec.js (1 hunks)
  • examples/sites/demos/pc/app/grid/edit/trigger-mode-for-editing.spec.js (1 hunks)
  • examples/sites/demos/pc/app/grid/edit/trigger-mode-hm-editing.spec.js (1 hunks)
  • examples/sites/demos/pc/app/grid/editor/inner-editor.spec.js (1 hunks)
  • examples/sites/demos/pc/app/grid/event/valid-error-event.spec.js (1 hunks)
  • examples/sites/demos/pc/app/grid/faq/grid-in-dialog-box.spec.js (1 hunks)
  • examples/sites/demos/pc/app/grid/pager/show-save-msg.spec.js (1 hunks)
  • examples/sites/demos/pc/app/grid/toolbar/save-data.spec.js (1 hunks)
  • examples/sites/demos/pc/app/grid/tree-table/tree-grid-insert-delete-update.spec.js (1 hunks)
  • examples/sites/demos/pc/app/grid/validation/before-submit-validation.spec.js (1 hunks)
  • examples/sites/demos/pc/app/grid/validation/custcomp.spec.js (1 hunks)
  • examples/sites/demos/pc/app/grid/validation/editing-isvalidalways-validation.spec.js (1 hunks)
  • examples/sites/demos/pc/app/grid/validation/editing-validation.spec.js (1 hunks)
  • examples/sites/demos/pc/app/grid/validation/row-data-valid.spec.js (1 hunks)
  • examples/sites/demos/pc/app/grid/validation/select-validation.spec.js (1 hunks)
  • examples/sites/demos/pc/app/grid/validation/tipconfig.spec.js (1 hunks)
  • examples/sites/demos/pc/app/grid/validation/validation-scroll-to-col.spec.js (1 hunks)
  • examples/sites/demos/pc/app/rich-text-editor/basic-usage-composition-api.vue (0 hunks)
  • examples/sites/demos/pc/app/rich-text-editor/basic-usage.vue (0 hunks)
  • examples/sites/demos/pc/app/rich-text-editor/collaboration-usage-composition-api.vue (0 hunks)
  • examples/sites/demos/pc/app/rich-text-editor/collaboration-usage.vue (0 hunks)
  • examples/sites/demos/pc/app/rich-text-editor/custom-bar-usage-composition-api.vue (0 hunks)
  • examples/sites/demos/pc/app/rich-text-editor/custom-bar-usage.vue (0 hunks)
  • examples/sites/demos/pc/app/rich-text-editor/event-usage-composition-api.vue (0 hunks)
  • examples/sites/demos/pc/app/rich-text-editor/event-usage.vue (0 hunks)
  • examples/sites/demos/pc/app/rich-text-editor/options-usage-composition-api.vue (0 hunks)
  • examples/sites/demos/pc/app/rich-text-editor/options-usage.vue (0 hunks)
  • examples/sites/demos/pc/app/rich-text-editor/placeholder-usage-composition-api.vue (0 hunks)
  • examples/sites/demos/pc/app/rich-text-editor/placeholder-usage.vue (0 hunks)
  • examples/sites/demos/pc/app/rich-text-editor/webdoc/rich-text-editor.cn.md (0 hunks)
  • examples/sites/demos/pc/app/rich-text-editor/webdoc/rich-text-editor.en.md (0 hunks)
  • examples/sites/demos/pc/app/rich-text-editor/webdoc/rich-text-editor.js (0 hunks)
  • examples/sites/demos/pc/app/time-picker/format.spec.ts (1 hunks)
  • examples/sites/demos/pc/webdoc/changelog.md (1 hunks)
  • examples/sites/demos/pc/webdoc/installation-en.md (0 hunks)
  • examples/sites/demos/pc/webdoc/installation.md (1 hunks)
  • examples/sites/package.json (3 hunks)
  • examples/sites/src/views/components/demo.vue (1 hunks)
  • examples/vue2.7/package.json (3 hunks)
  • examples/vue2/package.json (1 hunks)
  • examples/vue3/package.json (1 hunks)
  • internals/cli/src/shared/config.ts (1 hunks)
  • internals/cli/src/shared/module-utils.ts (1 hunks)
  • internals/playwright-config/package.json (1 hunks)
  • package.json (1 hunks)
  • packages/modules.json (1 hunks)
  • packages/theme/package.json (1 hunks)
  • packages/theme/src/theme-tool.d.ts (1 hunks)
  • packages/vue/package.json (1 hunks)
  • packages/vue/src/grid/package.json (1 hunks)
  • packages/vue/src/grid/src/table/src/events.ts (1 hunks)
  • packages/vue/src/grid/src/table/src/utils/autoCellWidth.ts (2 hunks)
  • packages/vue/src/grid/src/table/src/utils/handleGlobalKeydownEvent.ts (2 hunks)
  • packages/vue/src/rich-text-editor/package.json (2 hunks)
  • pnpm-workspace.yaml (1 hunks)

Finishing Touches

  • 📝 Generate Docstrings (Beta)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@zzcr zzcr closed this Jan 13, 2025
@petercat-assistant
Copy link

Walkthrough

This pull request introduces the release of version 3.21.0 for the tiny-vue project. It includes updates to various test files, package configurations, and documentation. The changes focus on enhancing grid functionalities, updating dependencies, and refining the rich-text editor component. Additionally, the changelog has been updated to reflect new features and bug fixes.

Changes

Files Summary
.github/workflows/auto-all-publish.yml, examples/docs/package.json, examples/sites/package.json, examples/vue2.7/package.json, examples/vue2/package.json, examples/vue3/package.json, internals/cli/src/shared/config.ts, internals/cli/src/shared/module-utils.ts, internals/playwright-config/package.json, package.json, packages/modules.json, packages/theme/package.json, packages/vue/package.json, packages/vue/src/grid/package.json, packages/vue/src/rich-text-editor/package.json, pnpm-workspace.yaml Updates to package configurations and dependencies.
examples/sites/demos/pc/app/grid/custom/.spec.js, examples/sites/demos/pc/app/grid/edit/.spec.js, examples/sites/demos/pc/app/grid/validation/*.spec.js, examples/sites/demos/pc/app/grid/event/valid-error-event.spec.js, examples/sites/demos/pc/app/grid/faq/grid-in-dialog-box.spec.js, examples/sites/demos/pc/app/grid/pager/show-save-msg.spec.js, examples/sites/demos/pc/app/grid/toolbar/save-data.spec.js, examples/sites/demos/pc/app/grid/tree-table/tree-grid-insert-delete-update.spec.js, examples/sites/demos/pc/app/time-picker/format.spec.ts Modifications to test files for grid and time-picker components.
examples/sites/demos/pc/app/rich-text-editor/.vue, examples/sites/demos/pc/app/rich-text-editor/webdoc/.md, examples/sites/demos/pc/app/rich-text-editor/webdoc/rich-text-editor.js Removal of rich-text editor examples and documentation.
examples/sites/demos/pc/webdoc/changelog.md Updated changelog with new features and bug fixes.
examples/sites/src/views/components/demo.vue Minor style adjustment.
packages/theme/src/theme-tool.d.ts Added new theme data declarations.
packages/vue/src/grid/src/table/src/events.ts, packages/vue/src/grid/src/table/src/utils/autoCellWidth.ts, packages/vue/src/grid/src/table/src/utils/handleGlobalKeydownEvent.ts Code refactoring and bug fixes in grid utilities.

isUpArrow,
isRightArrow,
isDwArrow: true,
isDownArrow: true,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable isDwArrow was renamed to isDownArrow. Ensure that this change is consistent throughout the codebase to prevent any potential issues.

// 如果是树形表格当前行回车移动到子节点
let childrens = currentRow[treeConfig.children]
if (childrens && childrens.length) {
const children = currentRow[treeConfig.children]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variable childrens was renamed to children. Ensure that this change is consistent throughout the codebase to prevent any potential issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants