fix(utils): fix popper flip error #3386
Conversation
WalkthroughThis change updates two utility functions and refactors variable names in the flip modifier logic within the PopperJS class. The scroll value functions now default to 0 when values are falsy, and variable names in the flip logic have been clarified for readability. No public API or control flow changes were made. Changes
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
packages/utils/src/popper/index.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🔇 Additional comments (4)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
WalkthroughThis PR addresses an issue where tooltips in tables were not flipping correctly. The changes involve adjustments to the logic determining the tooltip's position and flipping behavior, ensuring proper display. Changes
|
| @@ -188,10 +188,10 @@ const getOffsetRectRelativeToCustomParent = ( | |||
| } | |||
|
|
|||
| const getScrollTopValue = (el: HTMLElement) => | |||
| el === document.body ? Math.max(document.documentElement.scrollTop, document.body.scrollTop) : el.scrollTop | |||
| el === document.body ? Math.max(document.documentElement.scrollTop, document.body.scrollTop) : el.scrollTop || 0 | |||
There was a problem hiding this comment.
Ensure that el.scrollTop is always a number by providing a default value of 0. This prevents potential errors when el.scrollTop is undefined.
|
|
||
| const getScrollLeftValue = (el: HTMLElement) => | ||
| el === document.body ? Math.max(document.documentElement.scrollLeft, document.body.scrollLeft) : el.scrollLeft | ||
| el === document.body ? Math.max(document.documentElement.scrollLeft, document.body.scrollLeft) : el.scrollLeft || 0 |
There was a problem hiding this comment.
Ensure that el.scrollLeft is always a number by providing a default value of 0. This prevents potential errors when el.scrollLeft is undefined.
PR
修复表格中的tooltip不能正常翻转问题
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
Bug Fixes
Refactor