fix(textarea): Update the background color and related styles of the counter #3387

zzcr · 2025-05-07T08:21:50Z

fix(textarea): 更新计数器背景颜色和相关样式

PR

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our Commit Message Guidelines
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

Summary by CodeRabbit

Chores
- Updated internal workflow to improve detection of changes related to the textarea component for E2E testing.
Style
- Modified the appearance of the textarea character counter by removing its fixed width and border radius, and introducing a customizable background color.
- Adjusted the right offset of the textarea counter for improved alignment.
New Features
- Added a new CSS variable to allow customization of the textarea counter’s background color.

coderabbitai · 2025-05-07T08:21:59Z

Walkthrough

The changes update the GitHub Actions workflow to recognize the 'textarea' subcomponent as part of the 'input' component for E2E testing. In the theme package, the styling of the textarea counter is revised by introducing a new background color variable, adjusting its right offset, and modifying its CSS properties for appearance. Minor formatting fixes were applied to base theme variables.

Changes

Files/Paths	Change Summary
.github/workflows/test-e2e-pr.yml	Added 'textarea' to subComponentMapping, mapping it to 'input' for E2E test component detection.
packages/theme/src/textarea/index.less	Updated `.input-prefix-cls__count` styles: removed width and border radius, added background color.
packages/theme/src/textarea/vars.less	Introduced `--tv-Textarea-count-bg-color` variable; adjusted `--tv-Textarea-count-right` calculation.
packages/theme/src/base/vars.less	Fixed whitespace and formatting in comments and CSS variable declarations without functional change.

Poem

In the land of code where changes bloom,
A textarea’s counter gets a colorful room.
Mapped for tests, it joins input’s quest,
With background bright and offset dressed.
The rabbit hops and gives a cheer—
For tidy styles and workflows clear!
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 79e526d and ec44b48.

📒 Files selected for processing (2)

packages/theme/src/base/vars.less (2 hunks)
packages/theme/src/textarea/vars.less (2 hunks)

✅ Files skipped from review due to trivial changes (1)

packages/theme/src/base/vars.less

🚧 Files skipped from review as they are similar to previous changes (1)

packages/theme/src/textarea/vars.less

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: PR E2E Test (pnpm test:e2e3)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

petercat-assistant · 2025-05-07T08:22:10Z

Walkthrough

This PR updates the background color and related styles of the textarea counter in the tiny-vue project. It modifies the LESS files to introduce a new background color variable and adjusts the counter's right padding.

Changes

Files	Summary
packages/theme/src/textarea/index.less	Removed width and border-radius properties, added background color for the counter.
packages/theme/src/textarea/vars.less	Introduced a new variable for counter background color and adjusted the counter's right padding.
.github/workflows/test-e2e-pr.yml	Minor changes in the workflow configuration.

petercat-assistant · 2025-05-07T08:22:23Z

packages/theme/src/textarea/index.less

    padding-right: var(--tv-Textarea-count-padding-right);
+    background-color: var(--tv-Textarea-count-bg-color);


Ensure that the new background color variable --tv-Textarea-count-bg-color is defined and used correctly across all relevant components to avoid any styling issues.

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

packages/theme/src/textarea/index.less (1)
69-69: Add border-radius to the counter element for consistency
You introduced a background color for the counter but removed the previous border-bottom-left-radius. The --tv-Textarea-count-border-radius variable exists—apply it to the counter for consistent rounded corners:
 .@{input-prefix-cls}__count {
   padding-right: var(--tv-Textarea-count-padding-right);
   background-color: var(--tv-Textarea-count-bg-color);
+  border-radius: var(--tv-Textarea-count-border-radius);
 }

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f98b936 and 79e526d.

📒 Files selected for processing (3)

.github/workflows/test-e2e-pr.yml (1 hunks)
packages/theme/src/textarea/index.less (1 hunks)
packages/theme/src/textarea/vars.less (2 hunks)

🔇 Additional comments (3)

packages/theme/src/textarea/vars.less (2)

46-47: Introduce --tv-Textarea-count-bg-color
The new variable correctly defaults to the secondary background token, enabling customizable counter backgrounds.

57-57: Increase the counter right offset
Updating --tv-Textarea-count-right by 2px ensures proper positioning without relying on a fixed width.
.github/workflows/test-e2e-pr.yml (1)

109-110:
✅ Verification successful

Map textarea and svgs subcomponents for E2E detection
Adding 'textarea': 'input' ensures textarea changes trigger input tests. The 'svgs': 'icon' entry maps SVG asset updates to the icon component; please verify that the corresponding directories exist to match this mapping.

🏁 Script executed:
#!/bin/bash
# Verify that the 'svgs' and 'textarea' directories exist under packages/theme/src
for dir in svgs textarea; do
  if [ ! -d "packages/theme/src/$dir" ]; then
    echo "Directory $dir not found in packages/theme/src" && exit 1
  fi
done
echo "Required directories exist"
Length of output: 202
Verified subcomponent mappings for E2E detection
The svgs and textarea directories exist under packages/theme/src, so the mappings in .github/workflows/test-e2e-pr.yml are correct. No further changes needed.

fix(textarea): 更新计数器背景颜色和相关样式

79e526d

github-actions bot added the bug Something isn't working label May 7, 2025

petercat-assistant bot reviewed May 7, 2025

View reviewed changes

coderabbitai bot reviewed May 7, 2025

View reviewed changes

fix(theme): 修正vars.less中的背景颜色变量和格式问题

ec44b48

kagol approved these changes May 8, 2025

View reviewed changes

kagol merged commit aae01e8 into dev May 8, 2025
9 of 10 checks passed

kagol deleted the fix-input-text-area-0507 branch May 8, 2025 01:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(textarea): Update the background color and related styles of the counter #3387

fix(textarea): Update the background color and related styles of the counter #3387

zzcr commented May 7, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented May 7, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

petercat-assistant bot commented May 7, 2025

petercat-assistant bot May 7, 2025

coderabbitai bot left a comment

		padding-right: var(--tv-Textarea-count-padding-right);
		background-color: var(--tv-Textarea-count-bg-color);

fix(textarea): Update the background color and related styles of the counter #3387

fix(textarea): Update the background color and related styles of the counter #3387

Conversation

zzcr commented May 7, 2025 • edited by coderabbitai bot Loading

PR

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

Summary by CodeRabbit

coderabbitai bot commented May 7, 2025 • edited Loading

Walkthrough

Changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

petercat-assistant bot commented May 7, 2025

Walkthrough

Changes

petercat-assistant bot May 7, 2025

Choose a reason for hiding this comment

coderabbitai bot left a comment

Choose a reason for hiding this comment

zzcr commented May 7, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented May 7, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)