fix(date-picker):Fix the default time zone is not displayed #3389
Conversation
WalkthroughThe update refines the internal logic of the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant DatePanel
participant getRenderTz
User->>DatePanel: Request timezone data
DatePanel->>getRenderTz: Call with state.lang and value
getRenderTz->>getRenderTz: Normalize state.lang key
getRenderTz->>getRenderTz: Iterate and normalize value keys
getRenderTz->>getRenderTz: Match and assign timezone data
getRenderTz-->>DatePanel: Return timezone data
DatePanel-->>User: Provide timezone data
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
packages/renderless/src/date-panel/index.tsOops! Something went wrong! :( ESLint: 8.57.1 ESLint couldn't find the plugin "eslint-plugin-vue". (The package "eslint-plugin-vue" was not found when loaded as a Node module from the directory "".) It's likely that the plugin isn't installed correctly. Try reinstalling by running the following: The plugin "eslint-plugin-vue" was referenced from the config file in ".eslintrc.js » @antfu/eslint-config » @antfu/eslint-config-vue". If you still can't figure out the problem, please stop by https://eslint.org/chat/help to chat with the team. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (1)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Walkthrough此PR修复了默认时区不显示的问题。通过修改代码以确保在国际化语言中使用划线或下划线时能够正确匹配到时区数据。 Changes
|
| // 规避因国际化lang中划线以及下划线匹配不到时区数据 | ||
| const lang = state.lang.replace(/[-_]/g, '').toLowerCase() | ||
| Object.keys(value).forEach(key => { | ||
| if (key.replace(/[-_]/g, '').toLowerCase() === lang) { |
There was a problem hiding this comment.
确保在处理语言匹配时，替换后的语言键不会与现有键冲突。建议在替换语言键之前检查其唯一性，以避免潜在的数据覆盖问题。
WalkthroughThis PR fixes the issue where the default time zone is not displayed. Modify the code to ensure that time zone data can be correctly matched when using scribing or underscores in international languages. Changes
|
PR
修复默认时区不显示
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit