release notes and hard errors on no TOTP handler breaks partial auth events #824
+18
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dovholuknf
reviewed
Oct 15, 2025
|
|
||
| if context.ListenerCount(EventMfaTotpCode) == 0 { | ||
| return errors.New("no MFA TOTP code providers have been added via zitiContext.Events().AddMfaTotpCodeListener()") | ||
| pfxlog.Logger().Warn("no MFA TOTP code providers have been added via zitiContext.Events().AddMfaTotpCodeListener()") |
Member
There was a problem hiding this comment.
it didn't make sense to do this after emitting the event below? i assume this change was to still permit the event to be emitted, right? seems like you could do this after that emit and still return the error? just figured i'd ask
Member
Author
There was a problem hiding this comment.
It gunks up assumptions in other places I don't have time to fix now. It was originally a warning error and in my hubris I thought an error would be so much better.
dovholuknf
approved these changes
Oct 15, 2025
plorenz
added a commit
that referenced
this pull request
Oct 28, 2025
plorenz
added a commit
that referenced
this pull request
Nov 12, 2025
Fix context id data race. Fixes #824
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.