feat: field selectors support for InformerEventSource #2835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes #2813 |
xstefank
approved these changes
Jun 19, 2025
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
xstefank
approved these changes
Jun 20, 2025
| informer = | ||
| @Informer( | ||
| withFields = | ||
| @Field(field = "type", value = FieldSelectorTestReconciler.MY_SECRET_TYPE))) |
There was a problem hiding this comment.
This seems a little strange to me to read. Maybe "name" or "key" so it's not @Field(field = ... but of course this is just recommendation so feel free to discard it.
There was a problem hiding this comment.
Yes, it is a bit smelly.
Alternatively, we could have:
@FieldSelector(field="type", value="value", negated=false)
So there would not be with and without fields in @Informer just a list of @FieldSelector.
We might want to have similar api for java api for informers.
There was a problem hiding this comment.
@metacosm what do you think?
There was a problem hiding this comment.
refactored it to a more explicit model, PTAL
Signed-off-by: Attila Mészáros <[email protected]>
Signed-off-by: Attila Mészáros <[email protected]>
metacosm
requested changes
Jun 20, 2025
...ator-framework-core/src/main/java/io/javaoperatorsdk/operator/api/config/informer/Field.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Attila Mészáros <[email protected]>
metacosm
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Attila Mészáros [email protected]
closes #2813