Thanks to visit codestin.com
Credit goes to github.com

Skip to content

🐛 Add path to job workflow for go-verdiff #1954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2025
Merged

🐛 Add path to job workflow for go-verdiff #1954

merged 1 commit into from
May 6, 2025

Conversation

tmshort
Copy link
Contributor

@tmshort tmshort commented May 6, 2025

This appears to be confusing the jobs reporting.

Description

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@tmshort tmshort requested a review from a team as a code owner May 6, 2025 18:33
@netlify Netlify
Copy link

netlify bot commented May 6, 2025 •
edited
Loading

✅ Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit ceb3cbb
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/681a59e8d6b11a0008081d74
😎 Deploy Preview https://deploy-preview-1954--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented May 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.77%. Comparing base (061da6a) to head (ceb3cbb).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1954      +/-   ##
==========================================
- Coverage   66.81%   66.77%   -0.05%     
==========================================
  Files          75       75              
  Lines        6335     6335              
==========================================
- Hits         4233     4230       -3     
- Misses       1839     1841       +2     
- Partials      263      264       +1
Flag Coverage Δ
e2e 45.21% <ø> (-0.07%) ⬇️
unit 56.36% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@tmshort
Add path to job workflow for go-verdiff
ceb3cbb 
This appears to be confusing the jobs reporting.

Signed-off-by: Todd Short <[email protected]>
@tmshort tmshort changed the title 🐛 Remove "name" field from go-verdiff workflow Add path to job workflow for go-verdiff May 6, 2025
@tmshort tmshort changed the title Add path to job workflow for go-verdiff 🐛 Add path to job workflow for go-verdiff May 6, 2025
@tmshort
Copy link
Contributor Author

tmshort commented May 6, 2025

/approve

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2025
@grokspawn
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 6, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: grokspawn, tmshort

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@grokspawn grokspawn added this pull request to the merge queue May 6, 2025
@tmshort tmshort removed this pull request from the merge queue due to a manual request May 6, 2025
@tmshort tmshort added this pull request to the merge queue May 6, 2025
Merged via the queue into operator-framework:main with commit e29efc6 May 6, 2025
21 of 25 checks passed
@tmshort tmshort deleted the fix-go-verdiff branch May 6, 2025 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grokspawn grokspawn grokspawn approved these changes

@gavinmbell gavinmbell Awaiting requested review from gavinmbell

@rashmigottipati rashmigottipati Awaiting requested review from rashmigottipati

Assignees

@grokspawn grokspawn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmshort @grokspawn