🐛 Ease CI requirements for go-verdiff and codecov #1955
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/approve |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1955 +/- ##
=======================================
Coverage 66.77% 66.77%
=======================================
Files 75 75
Lines 6335 6335
=======================================
Hits 4230 4230
Misses 1841 1841
Partials 264 264
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -1,9 +1,6 @@ | |||
| name: go-verdiff | |||
| on: | |||
| pull_request: | |||
| paths: | |||
| - '**.mod' | |||
| - '.github/workflows/go-verdiff.yaml' | |||
There was a problem hiding this comment.
We should only run it when we change the go,mod and the action itself right?
There was a problem hiding this comment.
The problem is that GHA conditional stuff by path doesn't seem to align with prow/tide's idea of optional. So when there aren't changes in the path tripwires, tide waits forever for status that will never come (since the GHA doesn't run).
There was a problem hiding this comment.
I would personally prefer that we find a way to make prow better-informed about conditionality so that we could continue doing targeted CI upstream, which generally makes sense.
There was a problem hiding this comment.
It's causing problems when it's a required test; it doesn't provide any results. So, we need to have it run all the time if we want to make it a required test.
There was a problem hiding this comment.
In other words, "This is a required test, but oh, I'm only supposed to run it when these files are changed." So, unless those file are changed, it doesn't run, doesn't generate any results, and thus the CI hangs waiting for it.
1) Remove path from now-required go-verdiff CI We're experiencing a weird behavior with this CI being required, and running only on certain paths. 2) Add a 2% threshold for codecov Signed-off-by: Todd Short <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: camilamacedo86, grokspawn, tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bfac51c
into
operator-framework:main
We're experiencing a weird behavior with this CI being required, and running only on certain paths.
Description
Reviewer Checklist