Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Batch event processor #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 32 commits into from
Aug 16, 2019
Merged

Batch event processor #202

Changes from 1 commit
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
901d8f1
fix: remove unsupported package.
Jul 25, 2019
39113c3
Update .travis.yml
mariamjamal94 Jul 25, 2019
94e5df0
Update .travis.yml
mariamjamal94 Jul 25, 2019
8687672
Update .travis.yml
mariamjamal94 Jul 25, 2019
520f62c
Update .travis.yml
mariamjamal94 Jul 25, 2019
feb445b
Merge branch 'master' of https://github.com/Mariamjamal32/python-sdk
Jul 29, 2019
ae18085
Merge branch 'master' into mjamal/event_factory
Jul 29, 2019
90e694b
Merge branch 'mjamal/event_factory' of https://github.com/Mariamjamal…
Jul 29, 2019
d73e8cb
fix: resolve issues in _create_visitor class method
Jul 29, 2019
501b9c5
Merge branch 'master' of git://github.com/optimizely/python-sdk
Aug 1, 2019
018fb2d
Merge branch 'master' into mjamal/event_factory
Aug 1, 2019
e81e9a5
feat: add event_processor interface to support batch event processing.
Aug 1, 2019
ad59496
Merge remote-tracking branch 'remotes/upstream/sohail/pr-193' into ba…
Aug 1, 2019
fed4697
Merge branch 'sohail/pr-193' into batch_event_processor
mnoman09 Aug 1, 2019
f36754e
sync batch_event_processor with pr-193.
Aug 1, 2019
9f5f80d
Merge branch 'batch_event_processor' of https://github.com/Mariamjama…
Aug 1, 2019
32494b9
Update event_processor.py
mariamjamal94 Aug 2, 2019
373ef41
update: cater review comments.
Aug 2, 2019
0125d9f
update: review suggestions addressed.
Aug 7, 2019
59c5416
fix: address review comment to add abstract method from ABC in event_…
Aug 8, 2019
5c0632c
update event/event_processor.py
Aug 9, 2019
dce8efb
fix: remove stop and add close method in BatchEventProcessor.
Aug 9, 2019
6aca4ff
fix: reset indentation.
Aug 9, 2019
2d8d947
update BatchEventProcessor.
Aug 9, 2019
9171484
fix: remove stop from test_event_processor.
Aug 9, 2019
d52be4f
fix: logger level.
Aug 15, 2019
f55d6cf
update: fallback to defaults for invalid and negative values BatchEve…
Aug 16, 2019
3e55e2e
fix: linter error.
Aug 16, 2019
3154499
update: review suggestion catered.
Aug 16, 2019
06b5c25
update: import convention.
Aug 16, 2019
aab5ab4
update: remove uncertain log tests.
Aug 16, 2019
f4c23b1
update: handle 0ms flush_interval condition.
Aug 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update: remove uncertain log tests.
  • Loading branch information
[email protected] authored and [email protected] committed Aug 16, 2019
commit aab5ab402a2289bd1dfbb6297840f4d3087bd2e7
12 changes: 0 additions & 12 deletions tests/test_event_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,6 @@ def test_drain_on_close(self):

user_event = self._build_conversion_event(self.event_name)
self._event_processor.process(user_event)
mock_config_logging.debug.assert_called_with('Received user_event: ' + str(user_event))
event_dispatcher.expect_conversion(self.event_name, self.test_user_id)

time.sleep(5)
Expand All @@ -159,7 +158,6 @@ def test_flush_on_max_timeout(self):

user_event = self._build_conversion_event(self.event_name)
self._event_processor.process(user_event)
mock_config_logging.debug.assert_called_with('Received user_event: ' + str(user_event))
event_dispatcher.expect_conversion(self.event_name, self.test_user_id)

time.sleep(1.5)
Expand All @@ -176,7 +174,6 @@ def test_flush_max_batch_size(self):
for i in range(0, self.MAX_BATCH_SIZE):
user_event = self._build_conversion_event(self.event_name)
self._event_processor.process(user_event)
mock_config_logging.debug.assert_called_with('Received user_event: ' + str(user_event))
event_dispatcher.expect_conversion(self.event_name, self.test_user_id)

time.sleep(1)
Expand All @@ -192,12 +189,10 @@ def test_flush(self):

user_event = self._build_conversion_event(self.event_name)
self._event_processor.process(user_event)
mock_config_logging.debug.assert_called_with('Received user_event: ' + str(user_event))
self._event_processor.flush()
event_dispatcher.expect_conversion(self.event_name, self.test_user_id)

self._event_processor.process(user_event)
mock_config_logging.debug.assert_called_with('Received user_event: ' + str(user_event))
self._event_processor.flush()
event_dispatcher.expect_conversion(self.event_name, self.test_user_id)

Expand All @@ -217,15 +212,13 @@ def test_flush_on_mismatch_revision(self):

user_event_1 = self._build_conversion_event(self.event_name, self.project_config)
self._event_processor.process(user_event_1)
mock_config_logging.debug.assert_called_with('Received user_event: ' + str(user_event_1))
event_dispatcher.expect_conversion(self.event_name, self.test_user_id)

self.project_config.revision = 2
self.project_config.project_id = 'X'

user_event_2 = self._build_conversion_event(self.event_name, self.project_config)
self._event_processor.process(user_event_2)
mock_config_logging.debug.assert_called_with('Received user_event: ' + str(user_event_2))
event_dispatcher.expect_conversion(self.event_name, self.test_user_id)

time.sleep(1.5)
Expand All @@ -244,15 +237,13 @@ def test_flush_on_mismatch_project_id(self):

user_event_1 = self._build_conversion_event(self.event_name, self.project_config)
self._event_processor.process(user_event_1)
mock_config_logging.debug.assert_called_with('Received user_event: ' + str(user_event_1))
event_dispatcher.expect_conversion(self.event_name, self.test_user_id)

self.project_config.revision = 1
self.project_config.project_id = 'Y'

user_event_2 = self._build_conversion_event(self.event_name, self.project_config)
self._event_processor.process(user_event_2)
mock_config_logging.debug.assert_called_with('Received user_event: ' + str(user_event_2))
event_dispatcher.expect_conversion(self.event_name, self.test_user_id)

time.sleep(1.5)
Expand All @@ -268,7 +259,6 @@ def test_stop_and_start(self):

user_event = self._build_conversion_event(self.event_name, self.project_config)
self._event_processor.process(user_event)
mock_config_logging.debug.assert_called_with('Received user_event: ' + str(user_event))
event_dispatcher.expect_conversion(self.event_name, self.test_user_id)

time.sleep(1.5)
Expand All @@ -277,14 +267,12 @@ def test_stop_and_start(self):
self._event_processor.close()

self._event_processor.process(user_event)
mock_config_logging.debug.assert_called_with('Received user_event: ' + str(user_event))
event_dispatcher.expect_conversion(self.event_name, self.test_user_id)

self._event_processor.start()
self.assertStrictTrue(self._event_processor.is_started)

self._event_processor.close()
mock_config_logging.warning.assert_called_with('Stopping Scheduler.')
self.assertStrictFalse(self._event_processor.is_started)

self.assertEqual(0, self._event_processor.event_queue.qsize())
Expand Down