Thanks to visit codestin.com
Credit goes to github.com

Skip to content

tests: Fix intemittent multithreaded unit test failure #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Sep 20, 2019
Merged

tests: Fix intemittent multithreaded unit test failure #210

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5a39141
tests: fix intermittent failure
oakbani Sep 17, 2019
7c30eb1
add timeout
oakbani Sep 17, 2019
a0b7460
Wait for 5 seconds
oakbani Sep 17, 2019
d9d9f2d
make it wait for 10 to confirm that it's not the delay issue
oakbani Sep 18, 2019
daafa4b
make update interval small
oakbani Sep 18, 2019
e80aa16
Revert "tests: fix intermittent failure"
oakbani Sep 18, 2019
b48f7fb
do not assert mocked object
oakbani Sep 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make update interval small
  • Loading branch information
@oakbani
oakbani committed Sep 18, 2019
commit daafa4be864bd6e8ee01925c2c35299d9a4199b1
1 change: 1 addition & 0 deletions optimizely/config_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,7 @@ def _run(self):
try:
while self.is_running:
self.fetch_datafile()
self.logger.debug("This thread is running")
time.sleep(self.update_interval)
except (OSError, OverflowError) as err:
self.logger.error('Error in time.sleep. '
Expand Down
7 changes: 4 additions & 3 deletions tests/test_config_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,11 +282,12 @@ def test_is_running(self, _):
blocking_queue = queue.Queue()
with mock.patch('optimizely.config_manager.PollingConfigManager.fetch_datafile',
side_effect=lambda: blocking_queue.put_nowait('fetch_datafile called')) as mock_fetch_datafile:
project_config_manager = config_manager.PollingConfigManager(sdk_key='some_key')
project_config_manager = config_manager.PollingConfigManager(
sdk_key='some_key', update_interval=1)

self.assertTrue(project_config_manager.is_running)
# Wait for 10 seconds before asserting mock
# Wait for 5 seconds before asserting mock
try:
blocking_queue.get(True, 10)
blocking_queue.get(True, 5)
except queue.Empty:
mock_fetch_datafile.assert_called_with()