Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[FSSDK-11212] Update code to retry web API calls for fetching datafile and pushing events #445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Feb 26, 2025
Merged

[FSSDK-11212] Update code to retry web API calls for fetching datafile and pushing events #445

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f623b45
Update code to retry web API calls for fetching datafile and pushing …
Feb 24, 2025
b4b0ffe
Fix linting issues
Feb 24, 2025
ef9d993
Remove print statements
Feb 24, 2025
80bc26c
Fix up 'retries' member
Feb 24, 2025
f4c8173
Stub out requests.Session.get instead of requests.get
Feb 24, 2025
8624e1e
Update tests
Feb 24, 2025
d5ed569
Fix mypy error and linting error
Feb 24, 2025
44f5131
Update for tests
Feb 24, 2025
b7a585f
Update
Feb 24, 2025
8d7d22f
Update optimizely/event_dispatcher.py
pvcraven Feb 25, 2025
20a1f20
Update event dispatch to try three times to send events
Feb 25, 2025
551cb5e
Update changelog and version number
Feb 26, 2025
375ec2d
Update version number
Feb 26, 2025
4d74b59
Remove changelog and version update
Feb 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix linting issues
  • Loading branch information
Paul V Craven committed Feb 24, 2025
commit b4b0ffe0bd555c43f69eb43368db1736827f7cb7
8 changes: 4 additions & 4 deletions optimizely/config_manager.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,12 +400,12 @@ def fetch_datafile(self) -> None:

retries = Retry(total=self.retries,
backoff_factor=0.1,
status_forcelist=[ 500, 502, 503, 504 ])
status_forcelist=[500, 502, 503, 504])
adapter = HTTPAdapter(max_retries=retries)

session.mount('http://', adapter)
session.mount("https://", adapter)
response = session.get(self.datafile_url, timeout=enums.ConfigManager.REQUEST_TIMEOUT)
response = session.get(self.datafile_url, timeout=enums.ConfigManager.REQUEST_TIMEOUT)
except requests_exceptions.RequestException as err:
self.logger.error(f'Fetching datafile from {self.datafile_url} failed. Error: {err}')
return
Expand Down Expand Up @@ -492,12 +492,12 @@ def fetch_datafile(self) -> None:

retries = Retry(total=self.retries,
backoff_factor=0.1,
status_forcelist=[ 500, 502, 503, 504 ])
status_forcelist=[500, 502, 503, 504])
adapter = HTTPAdapter(max_retries=retries)

session.mount('http://', adapter)
session.mount("https://", adapter)
response = session.get(self.datafile_url, timeout=enums.ConfigManager.REQUEST_TIMEOUT)
response = session.get(self.datafile_url, timeout=enums.ConfigManager.REQUEST_TIMEOUT)
except requests_exceptions.RequestException as err:
self.logger.error(f'Fetching datafile from {self.datafile_url} failed. Error: {err}')
return
Expand Down
4 changes: 2 additions & 2 deletions optimizely/event_dispatcher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,15 +50,15 @@ def dispatch_event(event: event_builder.Event) -> None:

retries = Retry(total=EventDispatchConfig.REQUEST_TIMEOUT,
backoff_factor=0.1,
status_forcelist=[ 500, 502, 503, 504 ])
status_forcelist=[500, 502, 503, 504])
adapter = HTTPAdapter(max_retries=retries)

session.mount('http://', adapter)
session.mount("https://", adapter)

if event.http_verb == HTTPVerbs.GET:
session.get(event.url, params=event.params,
timeout=EventDispatchConfig.REQUEST_TIMEOUT).raise_for_status()
timeout=EventDispatchConfig.REQUEST_TIMEOUT).raise_for_status()
elif event.http_verb == HTTPVerbs.POST:
session.post(
event.url, data=json.dumps(event.params), headers=event.headers,
Expand Down
Loading