[FSSDK-11362] Fix CSRF security warning #448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 23, 2025 15:42
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the CSRF security warning issue by enabling CSRF protection in a Flask test application to better demonstrate secure practices, even in test scenarios.
- Moved and updated Flask imports to include CSRFProtect.
- Initialized CSRF protection for the test app.
- Added a lint directive for a global variable declaration in the after_request handler.
| from optimizely.helpers import enums | ||
|
|
||
| app = Flask(__name__) | ||
| # Initialize CSRF protection | ||
| csrf = CSRFProtect(app) |
There was a problem hiding this comment.
Enabling CSRF protection in the test application may cause tests to fail if CSRF tokens are not provided. Consider updating your test configuration or request simulation to correctly handle CSRF tokens.
Copilot uses AI. Check for mistakes.
mikechu-optimizely
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Run tests.
Issues