Aws secretsmanager add type and json key support #168
Conversation
...-aws/src/main/java/oracle/jdbc/provider/aws/configuration/AwsJsonSecretsManagerProvider.java
Outdated
Show resolved
Hide resolved
...-aws/src/main/java/oracle/jdbc/provider/aws/configuration/AwsJsonSecretsManagerProvider.java
Outdated
Show resolved
Hide resolved
|
Some of the tests failed. Can you please check? |
I’ve looked into the failures, and they don’t seem to be related to the changes in this PR. They’re coming from existing tests in the Azure provider and are also failing on the main branch. |
|
@MouhsinElmajdouby It seems to be related to the credential TEST_AZURE_CLIENT_SECRET which was expired. I've asked the admin to update the value and now the tests that failed were related to the Harshicorp Provider. But I agree that either is not tied to this PR. |
|
@MouhsinElmajdouby now that Ting's PR has been merged, can you please refresh your branch and rerun the tests? |
Tests passed after merging main. |
This PR updates the
AwsJsonSecretsManagerProviderto add the requiredtypeparameter and enhance the secret extraction logic. When the secret is stored as a JSON object, an optionalfield_namecan be used to select the desired key; if only one key exists, its value is used automatically. Additionally, when the secret is stored as plain text, it is used directly without further processing. Documentation has been updated to reflect these changes.