Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Partial validate of Docker-Content-Digest when downloading or getting blob #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2025
Merged

Partial validate of Docker-Content-Digest when downloading or getting blob #299

merged 1 commit into from
May 4, 2025

Conversation

jonesbusy
Copy link
Collaborator

@jonesbusy jonesbusy commented May 3, 2025 •
edited
Loading

Description

Validate Docker-Content-Digest if present when downloading or getting blob

Testing done

Submitter checklist

  • I have read and understood the CONTRIBUTING guide
  • I have run mvn license:update-file-header, mvn spotless:apply, pre-commit run -a, mvn clean install before opening the PR

@jonesbusy jonesbusy force-pushed the feature/better-digest-validation branch 3 times, most recently from d303175 to 5cd0eb1 Compare May 4, 2025 08:20
@jonesbusy
Better digest validation
7d83256 
Signed-off-by: Valentin Delaye <[email protected]>
@jonesbusy jonesbusy force-pushed the feature/better-digest-validation branch from 5cd0eb1 to 7d83256 Compare May 4, 2025 09:03
@codecov Codecov
Copy link

codecov bot commented May 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.70968% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.19%. Comparing base (1dcce09) to head (7d83256).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/main/java/land/oras/Registry.java 88.63% 3 Missing and 2 partials ⚠️
.../main/java/land/oras/utils/SupportedAlgorithm.java 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #299      +/-   ##
============================================
- Coverage     88.20%   88.19%   -0.01%     
- Complexity      561      570       +9     
============================================
  Files            39       39              
  Lines          1772     1813      +41     
  Branches        194      198       +4     
============================================
+ Hits           1563     1599      +36     
- Misses          132      134       +2     
- Partials         77       80       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonesbusy jonesbusy marked this pull request as ready for review May 4, 2025 09:06
@jonesbusy jonesbusy added the enhancement New feature or request label May 4, 2025
@jonesbusy jonesbusy changed the title Validate Docker-Content-Digest when downloading or getting blob Partial validate of Docker-Content-Digest when downloading or getting blob May 4, 2025
@jonesbusy jonesbusy merged commit ef46257 into oras-project:main May 4, 2025
4 checks passed
@jonesbusy jonesbusy deleted the feature/better-digest-validation branch May 4, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jonesbusy