Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Ensure to include parent folder into archive #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 14, 2025
Merged

Ensure to include parent folder into archive #356

merged 1 commit into from
Jul 14, 2025

Conversation

jonesbusy
Copy link
Collaborator

@jonesbusy jonesbusy commented Jul 14, 2025 •
edited
Loading

Description

Also fix nested folder. Previously only the folder name was taken which was not consistent with Go SDK

For example pushing src/main/java correctly set the title to src/main/java

Absolute path are also kept with original behavior (folder name). Expect they are now correctly packaged

    "layers": [
        {
            "annotations": {
                "io.deis.oras.content.digest": "sha256:13e37d5391939b4f2b1f43a2f0966ec2b02266555e0399d7dd40208a98bb987b",
                "io.deis.oras.content.unpack": "true",
                "org.opencontainers.image.title": "src/main/java"
            },
            "digest": "sha256:eddce30abed45c67998e27aeb250542576ecdf0e95afa9c843dbca3521bf22b0",
            "mediaType": "application/vnd.oci.image.layer.v1.tar+gzip",
            "size": 40871
        }
    ],

And is correctly pullable with oras pull

oras pull localhost:5000/foo:java
✓ Pulled      src/main/java                                                                                                                                                           39.9/39.9 KB 100.00%    9ms
  └─ sha256:eddce30abed45c67998e27aeb250542576ecdf0e95afa9c843dbca3521bf22b0
✓ Pulled      application/vnd.oci.image.manifest.v1+json                                                                                                                                741/741  B 100.00%     0s
  └─ sha256:a00a547cc8e8d23f398aaeb000ebdb542822fc303475cff8229d917aca1ee908
Pulled [registry] localhost:5000/foo:java
Digest: sha256:a00a547cc8e8d23f398aaeb000ebdb542822fc303475cff8229d917aca1ee908

Submitter checklist

  • I have read and understood the CONTRIBUTING guide
  • I have run mvn license:update-file-header, mvn spotless:apply, pre-commit run -a, mvn clean install before opening the PR

@jonesbusy
Consistent title with archive
07b24a9 
Signed-off-by: Valentin Delaye <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Jul 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.01%. Comparing base (2fbfc58) to head (07b24a9).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #356      +/-   ##
============================================
- Coverage     88.03%   88.01%   -0.03%     
- Complexity      629      632       +3     
============================================
  Files            39       39              
  Lines          1897     1902       +5     
  Branches        213      215       +2     
============================================
+ Hits           1670     1674       +4     
- Misses          135      137       +2     
+ Partials         92       91       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jonesbusy jonesbusy added the bug Something isn't working label Jul 14, 2025
@jonesbusy jonesbusy merged commit 1cde062 into oras-project:main Jul 14, 2025
5 checks passed
@jonesbusy jonesbusy deleted the bugfix/archive branch July 14, 2025 11:28
@jonesbusy jonesbusy mentioned this pull request Jul 14, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jonesbusy