optmize docker image (issue #113)#116
Merged
Merged
Conversation
now 170mb
Contributor
Author
|
for whatever reason certifi module is not available, so at run time it fails |
Contributor
|
I took a look at the Dockerfile again this morning given that you brought this. The "problem" here is that this change breaks numpy usage. Numpy was introduced with matplotlib from the times of the benchmarks with different dbs, but now that's no longer part of the CI. So, we have to either cleanup the pipenv (and Dockerfile) to completly remove all numpy-related unnecessary stuff, or properly adjust it to support numpy if we plan to use it in the short term (not sure yet if we'll need it after all). I'll get back to this after checking the other issues. |
Member
|
re-rested locally. seems to work flawlessly. closes #113 |
This was referenced Dec 18, 2018
Merged
c0c0n3
added a commit
that referenced
this pull request
Dec 19, 2018
* Fix edit docs link (GH #112) (#114) * Fix bug GH #115 (#117) * Geographical Queries Proposal (#111) * define ql geo-query api. * implement backbone of geo-queries. * document slf package * implement location attr handling. * implement pr suggestions. * use ngsi attr to represent centroid. * implement translation of ngsi geo queries to sql. * hook geo-query code into quantum leap. * close line string when converting box to polygon * use wkt for crate geo queries * missed this file in prev commit :-) * implement end-to-end tests. * enable geo queries independently of geo coding settings. * accept notifs with missing attr values. (#122) closes #110 * optmize docker image (issue #113) (#116) * optmize docker image now 170mb * Avoid pinned pipenv * bump up version number and add 0.5 release notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#113
now 170mb