fix: unhandled exception when category is unknown#663
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
✅ Deploy Preview for cookieconsentv3-playground canceled.
|
Owner
|
Could you elaborate a bit more? Like, when is the error thrown, with what config. |
Contributor
Author
Hi, yes of course. Whenever you enter a category that doesn't exist when checking for a service the whole call errors out, because it passes undefined to the next level function instead of an array. |
…Category` The small change prevents passing undefined to a function that expects an Array by providing a fallback.
Owner
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The small change prevents passing undefined to a function that expects an Array by providing a fallback.