pinger/src/linux.rs: use "ping -6" instead of "ping6"#546
Open
ryanmjacobs wants to merge 1 commit intoorf:masterfrom
Open
pinger/src/linux.rs: use "ping -6" instead of "ping6"#546ryanmjacobs wants to merge 1 commit intoorf:masterfrom
ryanmjacobs wants to merge 1 commit intoorf:masterfrom
Conversation
`ping6` does not exist on my system (`iputils 20250605-1`)
`gping -6` fails otherwise.
```
$ gping -6 example.com
Error: Error spawning ping: No such file or directory (os error 2)
Caused by:
No such file or directory (os error 2)
```
Note: Probably don't need to modify the BusyBox command.
However, `busybox ping` supports the same `-4/-6` flags:
```
$ busybox ping --help
...
-4,-6 Force IP or IPv6 name resolution
```
9f612a2 to
7ef8e1d
Compare
c1a6605 to
7ef8e1d
Compare
Author
|
@orf Do you mind reviewing this PR? Without it, I have to copy around a self-compiled to newer systems. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pinger/src/linux.rs: use "ping -6" instead of "ping6"
ping6does not exist on my system (iputils 20250605-1)gping -6fails otherwise.Note: Probably don't need to modify the BusyBox command.
However,
busybox pingsupports the same-4/-6flags: