Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@tranzystorekk
Copy link
Contributor

This time there's surprisingly few changes needed to make linuxwave work, definitely unlike my own experience with porting my projects to 0.14 ...

@orhun
Copy link
Owner

orhun commented Mar 7, 2025

Ayooo, thanks a lot for the PR! Can you also look into why the CI is failing 👀

@tranzystorekk
Copy link
Contributor Author

At least the non-docker part seems to be because the github actions runner's Ubuntu version no longer has the kcov package? Is coverage an important part for you for linuxwave? Cause personally it feels we have much too few tests and overall codebase size for it to be useful...

@orhun
Copy link
Owner

orhun commented Mar 7, 2025

Yeah good point... But I set it up once and it was working. Don't we just need to find the correct package and install it to fix it?

@tranzystorekk
Copy link
Contributor Author

tranzystorekk commented Mar 7, 2025

You're making a good point too. I'm not extremely familiar with the Ubuntu ecosystem, but from https://answers.launchpad.net/ubuntu/+source/kcov/+question/818841 it seems Ubuntu 24 is just lagging behind on repackaging from Debian. I'm not sure if Github allows changing the Ubuntu runner release to sth older?

EDIT: yep, going back to 22.04 did the trick

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (main@8c67bf7). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/main.zig 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main      #40   +/-   ##
=======================================
  Coverage        ?   66.04%           
=======================================
  Files           ?        4           
  Lines           ?      162           
  Branches        ?        0           
=======================================
  Hits            ?      107           
  Misses          ?       55           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@orhun
Copy link
Owner

orhun commented Mar 7, 2025

Ah, got it. It seems like it's fixed! I guess we just need to update the Dockerfile for Zig 0.14 I believe.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good shit

@orhun orhun merged commit c1e43ce into orhun:main Mar 7, 2025
7 checks passed
@tranzystorekk tranzystorekk deleted the zig14 branch March 7, 2025 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants