Fixed flaky test-case testBeanToListGeneration() in class BeanToListGenerationTestCase#404
Open
hermya wants to merge 1 commit intoorika-mapper:masterfrom
Open
Fixed flaky test-case testBeanToListGeneration() in class BeanToListGenerationTestCase#404hermya wants to merge 1 commit intoorika-mapper:masterfrom
hermya wants to merge 1 commit intoorika-mapper:masterfrom
Conversation
…enerationTestCase
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix is similar to a previous PR : #403
POINT OF FAILURE -> random attribute ordering produced by factory.classMap(Clazz, Clazz) When field(fromClassField, toClassField) is not called for all hierarchical attributes, the one left out will appear in random order.
Example:
and when --""--.field("b.c", "0") is called, (converting obj to
List<Object>)the mapped destination
List<Object>could be: [2, 1, 3] OR [2, 3, 1]Possible fix: for all unmapped attrs, use lexographical ordering or throw exception
Fixed using NonDex, plugin added in parent pom.
Suggested command to check flaky tests :
For particular test:
For more information : https://github.com/TestingResearchIllinois/NonDex