Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@meyerj
Copy link
Member

@meyerj meyerj commented May 18, 2020

Related PR in rtt: orocos-toolchain/rtt#321
and ocl: orocos-toolchain/ocl#90

Format 3 is the latest specification of ROS package manifests (REP-0149).

Changes in manifest.xml are pure formatting.

... and the authors have been merged in tag <author>. <copyright> is not a valid tag according to the ROS spec.

The license tags in manifest.xml and package.xml have been wrong. log4cpp does not explicitly allow later versions of the LGPL v2.1 in its original COPYING file.

@meyerj meyerj requested a review from doudou May 18, 2020 17:27
@meyerj
Copy link
Member Author

meyerj commented May 18, 2020

The license tags in manifest.xml and package.xml have been wrong. log4cpp does not explicitly allow later versions of the LGPL v2.1 in its original COPYING file.

Correction: In doc/html/index.html and on the web page the license text has the "or (at your option) any later version" extension.

@snrkiwi
Copy link
Contributor

snrkiwi commented May 19, 2020

And again ...

I think we should be consistent and write down what versions of things (e.g. operating system, ROS versions, catkin, compilers, etc.) that we support. Then the version of the XML format should be driven by that. At the moment it seems kind of scattershot ...

@meyerj
Copy link
Member Author

meyerj commented Nov 30, 2021

And again ...

I think we should be consistent and write down what versions of things (e.g. operating system, ROS versions, catkin, compilers, etc.) that we support. Then the version of the XML format should be driven by that. At the moment it seems kind of scattershot ...

See my response at orocos-toolchain/rtt#321 (comment):

  • This patch does not change any dependency except for catkin_pkg if catkin is used as a build tool, which is considered safe for all relevant distributions since Ubuntu Trusty.
  • The patch is required to build with ROS 2-related build tools.
  • Requirements are documented at https://docs.orocos.org/docs_main/installation.html in the meantime.

@meyerj meyerj merged commit fc97f30 into toolchain-2.9 Nov 30, 2021
@meyerj meyerj deleted the package-xml-format-3 branch November 30, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants