cmake: Correctly set RPATH accounting for OS X and CMake versions #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids the following error (OS X 10.11, SIP enabled, CMake 3.6) -- Configuring done CMake Warning (dev): Policy CMP0042 is not set: MACOSX_RPATH is enabled by default. Run "cmake --help-policy CMP0042" for policy details. Use the cmake_policy command to set the policy and suppress this warning. MACOSX_RPATH is not specified for the following targets: log4cpp This warning is for project developers. Use -Wno-dev to suppress it. -- Generating done
Member
|
LGTM and we have similar cmake code in UseOROCOS-RTT-helpers.cmake. Another solution, at least for CMake 2.8.12 and later, would be to set the cmake_policy CMP0042 to new and enable RPATH somewhere in the beginning: cmake_minimum_required(VERSION 2.8.12)
if(POLICY CMP0042)
cmake_policy(SET CMP0042 NEW)
endif()
if(NOT DEFINED CMAKE_MACOSX_RPATH)
set(CMAKE_MACOSX_RPATH ON)
endif()Maybe we should prefer this shorter code snippet for all Orocos projects and drop support for older CMake versions? The |
Contributor
Author
|
IIRC you can't simplify the logic that much. Ruben and I spent time hacking at this a long time ago, and the logic above (which I did indeed lift from RTT) is required. Having said that, I'd personally be happy to simplify to CMake >= 2.8.12. We are in the process of doing exactly that to all our internal projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids the following error (OS X 10.11, SIP enabled, CMake 3.6)
-- Configuring done
CMake Warning (dev):
Policy CMP0042 is not set: MACOSX_RPATH is enabled by default. Run "cmake
--help-policy CMP0042" for policy details. Use the cmake_policy command to
set the policy and suppress this warning.
MACOSX_RPATH is not specified for the following targets:
log4cpp
This warning is for project developers. Use -Wno-dev to suppress it.
-- Generating done
Tested on OS X 10.11/SIP enabled/CMake 3.6, and Mint 17.0/CMake 2.8.12.