Revert "Use O_LARGEFILE when creating log files on non-APPLE platforms." #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s." (fix orocos-toolchain#8) This reverts commit eacabaf. Configuring large file system (LFS) support is a build system issue and should not be tackled by code changes. O_LARGEFILE is a GNU extension and is not supported on all platforms. If still required, the `-D_FILE_OFFSET_BITS=64` should be added to the compiler command line via CMake. See http://man7.org/linux/man-pages/man7/feature_test_macros.7.html.
|
Thanks for your reply, i will use cmake to rebuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #8. This reverts commit eacabaf.
Configuring large file system (LFS) support is a build system issue and should not be tackled by code changes.
O_LARGEFILEis a GNU extension and is not supported on all platforms. If still required, the-D_FILE_OFFSET_BITS=64option should be added to the compiler command line via CMake.See also section about
O_LARGEFILEin http://man7.org/linux/man-pages/man2/open.2.html and http://man7.org/linux/man-pages/man7/feature_test_macros.7.html.