This repository was archived by the owner on Jan 3, 2023. It is now read-only.
upgrade RN 0.43.4; add e2e test; android can work again #92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…param comes from function
… Also it's an example needed by codeceptjs/CodeceptJS#728
…b` of branch `v1.1.x`
|
赞。 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
用 CodeceptJS 实现了 e2e test ，而且配合我最新的 react-web 以及
npm run patch-codeceptjs-webdriverio补丁（该补丁的 PR 也已经被 CodeceptJS 合并了），现在写 test case 也可以做到一次编写、 Android iOS Web 三处测试了 😆升级到了 RN 0.43.4 ，而且将你的 v1.1.x 分支的功能完好地合并到了 master 分支上。
现在 Android 和 Web 上都能通过基本的 e2e 测试。 iOS 能够在网上的 CI 工具里编译通过，没有运行过，但因为你在 v1.1.x 中说 iOS 是能够运行的，那应该运行也没问题。