-
-
Notifications
You must be signed in to change notification settings - Fork 116
feat: add support for OIDC auth #171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e15a300 to
ce65a5c
Compare
|
Hmm.. I don't see any tests that currently exist! I guess that makes it easier because I don't need to write tests but.. I don't have a way to validate there & require manual testing. |
ce65a5c to
dfe8c4c
Compare
|
after looking a bit, there's no support for login errors at all so I won't be modifying this to support them |
dfe8c4c to
b6c4fce
Compare
b6c4fce to
9ee932a
Compare
|
Rebased against main to handle conflicts |
|
Hi @imnotjames, I'd like to help test this and get it merged in. Any chance you've got a built image I can pull? |
|
@samiralam @imnotjames Are you still interested in working on this? |
|
If there's interest in it I can resolve the conflicts. Not sure what's needed to review it beyond that. |
I'm interested, and happy to help test. |
|
@imnotjames Yes, I would like to finally merge it 👍 |
|
@samiralam sounds good, let me know what provider you've used. I can build the image for you if you'd like, once this branch gets rebased |
9ee932a to
3161b22
Compare
|
@samiralam I have released an experimental build with OIDC support. Can you check if you can configure your provider with it? |
Awesome, I'll try it out this weekend and report back. |
|
I was able to get my provider (PocketID) to work. It does require setting your
|
4ecb598 to
c6948a0
Compare
c6948a0 to
e4c363f
Compare
adds support for OIDC authentication mechanisms
fixes #148