🐛 Ensure % character in the artifactLocation in sarif output are escaped #4619
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e9eda85 to
d1a8b1a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4619 +/- ##
==========================================
+ Coverage 66.80% 68.37% +1.56%
==========================================
Files 230 249 +19
Lines 16602 18814 +2212
==========================================
+ Hits 11091 12864 +1773
- Misses 4808 5097 +289
- Partials 703 853 +150 🚀 New features to boost your workflow:
|
spencerschrock
approved these changes
May 9, 2025
There was a problem hiding this comment.
Thank you! Could you please correct your last commit for DCO?
https://github.com/ossf/scorecard/pull/4619/checks?check_run_id=41958169840
Signed-off-by: Uwe L. Korn <[email protected]>
Signed-off-by: Uwe L. Korn <[email protected]>
Signed-off-by: Uwe L. Korn <[email protected]>
Done! Sorry, I'm not used to that. |
No worries, thanks for sending the patch. It's common for contributors to need to fix DCO. Keep an eye out for the next scorecard-action release. We are probably due for one soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
(Is it a bug fix, feature, docs update, something else?)
What is the current behavior?
Currently if a filename contains a
%character it is passed through in plain text in the result insariffile. If the location is later parsed again, an URL-decoder will stumble upon it as it tries decode the escape sequence.As an example see the following
scorecard-actionwhere the SARIF upload failed: https://github.com/Quantco/copier-template-python-open-source/actions/runs/14924466359What is the new behavior (if this is a feature change)?**
%characters are escaped in the SARIF output.Which issue(s) this PR fixes
NONE
Special notes for your reviewer
Does this PR introduce a user-facing change?
For user-facing changes, please add a concise, human-readable release note to
the
release-note(In particular, describe what changes users might need to make in their
application as a result of this pull request.)