Swapped email and email_client #59
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Completing the instructions in order would result in a bug because replacing email would cause email_client to be not found. Replacing email_client is acceptable solution because email can also be found.
othneildrew
approved these changes
Feb 17, 2022
Owner
othneildrew
left a comment
There was a problem hiding this comment.
Thanks for your contribution my friend :)
dotjasonhwang
pushed a commit
to dotjasonhwang/readme-template
that referenced
this pull request
Mar 21, 2025
Reorder instructions to avoid bugs where replacing email would cause email_client to be not found. Replacing email_client is the acceptable solution because email can also be found.
ashraf-kabir
pushed a commit
to ashraf-kabir/Best-README-Template
that referenced
this pull request
Jul 5, 2025
ashraf-kabir
pushed a commit
to ashraf-kabir/Best-README-Template
that referenced
this pull request
Jul 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completing the instructions in order would result in a bug because replacing email would cause email_client to be not found. Replacing email_client is acceptable solution because email can also be found.