Adjust Symfony eventDispatcher->dispatch calls#279
Merged
phil-davis merged 2 commits intomasterfrom Feb 7, 2020
Merged
Conversation
e0a1c46 to
23a7138
Compare
individual-it
approved these changes
Feb 6, 2020
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
=========================================
Coverage 73.52% 73.52%
Complexity 230 230
=========================================
Files 25 25
Lines 982 982
=========================================
Hits 722 722
Misses 260 260
Continue to review full report at Codecov.
|
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to owncloud/core#36897
We updated from Symfony 3.4 to 4.4 in PR #36881
Symfony 4.3 (and thus 4.4) adjusted the
EventDispatcherdispatchmethod to take parameters in the opposite order.https://symfony.com/blog/new-in-symfony-4-3-simpler-event-dispatching
symfony/symfony#28920
symfony/symfony#33115
The change was made in a BC way - if the parameters are provided the old way around, then the
dispatchmethod flips them. So existing code is OK. But in Symfony5 the "old way" is likely to have been removed.phancode analysis reports that the parameters are around the "wrong way" (the old way). e.g.Fix this to match the currently expected order of arguments