fix(web-app-files): reset selection only when path changes #12768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've changed the way we reset the selection when the route changes. Previously, we were resetting the selection when the route changed, but this was not working as expected. For example, when updating `scrollTo` route query, the selection was being unintentionally reset. Now, we're only resetting the selection when the path changes.
|
78 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've changed the way we reset the selection when the route changes.
Previously, we were resetting the selection when the route changed, but this was not working as expected. For example, when updating
scrollToroute query, the selection was being unintentionally reset.Now, we're only resetting the selection when the path changes.
Related Issue
Motivation and Context
Users can easily see the resource from the notification
How Has This Been Tested?
Screenshots (if appropriate):
Zaznam.obrazovky.2025-06-27.v.9.01.11.mov
Types of changes