fix(web-app-admin-settings): [OCISDEV-138] handle direct admin settings access #12780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the admin-settings routing to always redirect users to a permitted sub-route when accessing “/”, fixing the previous mismatch in permissions when opening the URL directly.
- Extracts the redirect logic into a new
getAvailableRoutehelper. - Changes the root redirect and individual
beforeEnterguards to usegetAvailableRoute.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| packages/web-app-admin-settings/src/index.ts | Extracted redirect logic and updated route guards |
| changelog/unreleased/bugfix-handle-direct-admin-settings-access.md | Added bugfix entry for direct URL access |
Comments suppressed due to low confidence (1)
packages/web-app-admin-settings/src/index.ts:25
- [nitpick] Consider adding unit tests for
getAvailableRouteto verify that it returns the correct route name for each permission set.
function getAvailableRoute(ability: Ability) {
…gs access Opening the admin settings directly by pasting the URL in the browser address bar or opening the app in a new tab now works correctly. The redirect was not correctly using the navigation guard leading to a mismatch in users permissions. We now redirect to the first available route and leave the route itself to handle the permissions navigation guard.
e931bce to
c416e52
Compare
mzner
approved these changes
Jul 3, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Opening the admin settings directly by pasting the URL in the browser address bar or opening the app in a new tab now works correctly. The redirect was not correctly using the navigation guard leading to a mismatch in users permissions. We now redirect to the first available route and leave the route itself to handle the permissions navigation guard.
Motivation and Context
Users can open admin settings by entering URL address.
How Has This Been Tested?
Types of changes