feat(oxlint/linter/lsp): apply bulk suppression baseline - #25093
feat(oxlint/linter/lsp): apply bulk suppression baseline#25093daniel-oliveira-figma wants to merge 34 commits into
Conversation
7f15a67 to
77f7c8e
Compare
Sysix
left a comment
There was a problem hiding this comment.
Thank you for the work ❤️
I had finally time to review the basic for LSP. I did not test it in a real editor, waiting for some team feedback, before manually testing it.
Co-authored-by: Alexander S. <[email protected]> Signed-off-by: Daniel Oliveira <[email protected]>
Sysix
left a comment
There was a problem hiding this comment.
Some small changes requested. Excited to test it in VSCode 🥳
Co-authored-by: Alexander S. <[email protected]> Signed-off-by: Daniel Oliveira <[email protected]>
|
🙏 thanks for the reviews @Sysix. I did some testing on vscode with a local build recently and it seemed to work as expected |
Merging this PR will not alter performance
Comparing Footnotes
|
Sysix
left a comment
There was a problem hiding this comment.
Thank you for the work. I could test it today with VSCode, everything looks good to me.
I added some commits, like hiding the LSP docs. The CLI does hide it currently too, we should align with CLI.
This now should align how @camchenry defined the implementation details in #22198 (comment)
Summary
Refs #21199 and follows the LSP decisions in #22198.
Teach the oxlint language server to apply
oxlint-suppressions.jsonwith the same count-based semantics as the CLI.Suppressed diagnostics remain visible by default at
warnseverity. Clients can selecthint,info,warn, orerror, or hide suppressed diagnostics withsuppressedViolationSeverity: "off".Implementation
DiffManagerto partition diagnostics into surfaced and suppressed groups without changing existing CLI behavior.oxlint-suppressions.jsonso baseline changes rebuild the linter and refresh open documents.Tests
Add coverage for:
off;Extension follow-up
This PR adds native language-server support and publishes
suppressedViolationSeverityin the LSP configuration schema. The officialoxc-vscodeextension does not yet expose or forward this option, so a follow-up extension PR is required for users to customize it through VS Code settings. The default visible-warnbehavior works without an extension change.Verification
cargo run -q -p website_linter schema-markdown-lspINSTA_UPDATE=always cargo test -q -p website_linter test_schema_markdown_lsp(1 passed)git diff upstream/main...HEAD --checkFull lint, build, typecheck, and test coverage is left to CI.
AI assistance
Codex was used to investigate, implement, test, and draft this change.