Thanks to visit codestin.com
Credit goes to github.com

Skip to content

perf(lsp): register only implemented methods - #25763

Open
Boshen wants to merge 1 commit into
09-12-chore_lsp_update_tower-lsp-server_to_0.24.0-rc.1from
agent/narrow-lsp-router
Open

perf(lsp): register only implemented methods#25763
Boshen wants to merge 1 commit into
09-12-chore_lsp_update_tower-lsp-server_to_0.24.0-rc.1from
agent/narrow-lsp-router

Conversation

@Boshen

@Boshen Boshen commented Aug 17, 2026 •
edited by Sysix
Loading

Copy link
Copy Markdown
Member

Registers only Oxlint's implemented LSP methods, reducing the release binary by 1,002.7 KiB (6.99%).

Depends on tower-lsp-server#81, which is included in 0.24.0-rc.1

AI assistance was used to prepare this change.

Validation: cargo test -p oxc_language_server; cargo clippy -p oxc_language_server --all-targets -- -D warnings.

@github-actions github-actions Bot added the A-editor Area - Editor and Language Server label Aug 17, 2026
@Boshen Boshen mentioned this pull request Aug 17, 2026
Merged
@codspeed-hq

codspeed-hq Bot commented Aug 17, 2026 •
edited
Loading

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 72 untouched benchmarks
⏩ 9 skipped benchmarks1

Comparing agent/narrow-lsp-router (e8828e1) with 09-12-chore_lsp_update_tower-lsp-server_to_0.24.0-rc.1 (51af350)

Open in CodSpeed

Footnotes

  1. 9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Sysix
Sysix reviewed Aug 17, 2026
View reviewed changes
Comment thread crates/oxc_language_server/src/lib.rs Outdated
@Sysix
Sysix changed the base branch from main to graphite-base/25763 September 12, 2026 20:05
@Sysix
Sysix force-pushed the agent/narrow-lsp-router branch from e16aee5 to 4853dfa Compare September 12, 2026 20:05
@Sysix
Sysix changed the base branch from graphite-base/25763 to 09-12-chore_lsp_update_tower-lsp-server_to_0.24.0-rc.1 September 12, 2026 20:05
@Sysix Graphite App

Sysix commented Sep 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@Sysix Sysix mentioned this pull request Sep 12, 2026
Open
@Sysix
Sysix force-pushed the agent/narrow-lsp-router branch 2 times, most recently from e74ccb9 to ba57398 Compare September 12, 2026 20:35
@Sysix
Sysix force-pushed the 09-12-chore_lsp_update_tower-lsp-server_to_0.24.0-rc.1 branch from b2ce755 to 01f029d Compare September 12, 2026 20:35
@Sysix
Sysix force-pushed the 09-12-chore_lsp_update_tower-lsp-server_to_0.24.0-rc.1 branch from 01f029d to 51af350 Compare September 12, 2026 21:11
@Sysix
Sysix force-pushed the agent/narrow-lsp-router branch from ba57398 to e8212c8 Compare September 12, 2026 21:11
@Sysix
Sysix marked this pull request as ready for review September 12, 2026 21:31
@Sysix
Sysix marked this pull request as draft September 13, 2026 01:03
@Sysix
Sysix force-pushed the agent/narrow-lsp-router branch from e8828e1 to e8212c8 Compare September 13, 2026 01:22
@Sysix
Sysix marked this pull request as ready for review September 13, 2026 01:22
@Sysix Sysix mentioned this pull request Sep 13, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sysix Sysix Sysix left review comments
@camc314 camc314 Awaiting requested review from camc314 camc314 is a code owner
@leaysgur leaysgur Awaiting requested review from leaysgur leaysgur is a code owner

Assignees

No one assigned

Labels

A-editor Area - Editor and Language Server

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Boshen @Sysix