Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(linter): change node/no-exports-assign category from style to suspicious - #26555

Open
Bartok9 wants to merge 1 commit into
oxc-project:mainfrom
Bartok9:fix/linter-no-exports-assign-category
Open

fix(linter): change node/no-exports-assign category from style to suspicious#26555
Bartok9 wants to merge 1 commit into
oxc-project:mainfrom
Bartok9:fix/linter-no-exports-assign-category

Conversation

@Bartok9

@Bartok9 Bartok9 commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Closes #26282. exports = {} is most likely a bug (reassigns the local exports binding, not module.exports), so it fits the suspicious category better than style. Test still passes.

AI disclosure: assisted by AI (Hermes/Sera); human-reviewed.
Agent-Owner:sera

@Bartok9
Bartok9 requested a review from camc314 as a code owner September 11, 2026 12:19
@codspeed-hq

codspeed-hq Bot commented Sep 11, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 5 untouched benchmarks
⏩ 76 skipped benchmarks1


Comparing Bartok9:fix/linter-no-exports-assign-category (a224cec) with main (66fda4f)

Open in CodSpeed

Footnotes

  1. 76 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

linter: node/no-exports-assign should be correctness or suspicious category

1 participant