fix(linter): print --rules catalog under agent output format - #26557
Open
Bartok9 wants to merge 1 commit into
Open
fix(linter): print --rules catalog under agent output format#26557Bartok9 wants to merge 1 commit into
Bartok9 wants to merge 1 commit into
Conversation
AgentOutputFormatter inherited InternalFormatter::all_rules → None, so `oxlint --rules` printed nothing and still exited 0 when the default format was auto-detected as agent (oxc-project#26343). Print the same RuleTable catalog as the default formatter. Closes oxc-project#26343
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
oxlint --ruleshas printed nothing (exit 0) since 1.66.0. Bisect notes in #26343 pointed at agent output format.When
default_output_format()auto-selectsOutputFormat::Agent(AI_AGENT / CLAUDECODE / CURSOR_AGENT / etc.),AgentOutputFormatterinheritedInternalFormatter::all_rules→None, sorun_ruleswrote an empty catalog.This implements
all_ruleson the agent formatter with the sameRuleTablecatalog as default.Test plan
cargo test -p oxlint --lib output_formatter::agent::test— 6 passed includingall_rules_prints_catalogoxlint --rulesin an agent env should print## Correctness/Total:instead of 0 bytesCloses #26343
Never
git reset --hard.