fix(minifier): drop bound console methods - #26568
Open
akashchamp wants to merge 2 commits into
Open
Conversation
Signed-off-by: Akash Kumar <[email protected]>
armano2
reviewed
Sep 11, 2026
| let scope_id = ctx.create_child_scope_of_current(ScopeFlags::Arrow | ScopeFlags::Function); | ||
| let empty_function = | ||
| Expression::new_arrow_function_expression_with_scope_id_and_pure_and_pife( | ||
| span, false, None, params, None, body, scope_id, false, false, ctx, |
Contributor
There was a problem hiding this comment.
this should be marked as pure true, false, ctx
Preserve no-side-effects metadata when replacing a bound console method. Signed-off-by: Akash Kumar <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
console.<method>receiver with a scoped empty arrow when a bound console method is retained undercompress.dropConsole.Closes #26373
Testing
cargo fmt --checkcargo test -p oxc_minifier --test mod drop_console— 2 passed.cargo test -p oxc_minifier --test mod— 703 passed, 0 failed, 33 ignored.cargo clippy -p oxc_minifier --all-targets --all-features -- -D warningscargo lintgen(() => {}).bind(console), emitted noconsole.logcall, and invoked the replacement-bound function.just readycould not start becausejustand its remaining JavaScript tool prerequisites are unavailable on the remote host.AI disclosure
AI assistance was used for PR development.