Thanks to visit codestin.com
Credit goes to github.com

Skip to content

perf(minfiier): reduce allocs when creating indirect access - #26601

Open
armano2 wants to merge 4 commits into
oxc-project:mainfrom
armano2:perf/indirect_access
Open

perf(minfiier): reduce allocs when creating indirect access#26601
armano2 wants to merge 4 commits into
oxc-project:mainfrom
armano2:perf/indirect_access

Conversation

@armano2

@armano2 armano2 commented Sep 13, 2026

Copy link
Copy Markdown
Contributor
  • simplify code for try_fold_conditional_expression
  • preserve_indirect_access should now preserve more accurate span range
  • try_fold_coalesce and try_fold_and_or reuses now preserve_indirect_access helper

@armano2
armano2 requested a review from Dunqing as a code owner September 13, 2026 13:48
armano2
armano2 commented Sep 13, 2026
View reviewed changes
Comment thread crates/oxc_minifier/src/peephole/remove_dead_code.rs
@codspeed-hq

codspeed-hq Bot commented Sep 13, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 62 untouched benchmarks
⏩ 19 skipped benchmarks1

Comparing armano2:perf/indirect_access (2fbb245) with main (1aa5ec1)

Open in CodSpeed

Footnotes

  1. 19 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@armano2

armano2 commented Sep 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

try_fold_coalesce and try_fold_and_or can be simplified, but that is going to be pretty big refactor and oo scope for this change

i'm not sure if this should be perf or refactor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Dunqing Dunqing Awaiting requested review from Dunqing Dunqing is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@armano2