Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

jeswr
Copy link
Contributor

@jeswr jeswr commented Mar 15, 2025

This PR:

  • Creates an examples directory and adds an example of running a query with explanation
  • Adds a script and CI to make sure that all toml files have newlines since this was not caught by cargo fmt.
  • Configures .cargo/cargo.toml for better dev performance/caching.

Running jointly as an experiment to test the capabilities of cursor ... which is quite impressive running with sonnet-3.7-thinking ... and so that I can see what is produced in an explanation. Figured this is a useful artefact that was produced in the process so may as well contribute it.

@jeswr jeswr marked this pull request as draft March 15, 2025 22:29
Copy link

codspeed-hq bot commented Mar 15, 2025

CodSpeed Performance Report

Merging #1213 will degrade performances by 7.95%

Comparing jeswr:feat/examples (e019da8) with main (68d45f7)

Summary

❌ 4 regressions
✅ 25 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
parse BSBM explore 1000 130.6 ms 136.2 ms -4.13%
parse BSBM explore 1000 unchecked 57.6 ms 61.3 ms -5.96%
oxttl ntriples[ntriples] 261.9 µs 284.5 µs -7.95%
oxttl turtle[ntriples] 347.8 µs 369.6 µs -5.91%

@Tpt
Copy link
Collaborator

Tpt commented Mar 16, 2025

Thank you for that. Cargo has some built-in support for examples so if you move the examples to the lib/oxigraph/examples directory you can then run an example by doing cargo run --package oxigraph --example foo to run the example foo.rs.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure we want to commit this file, it's something that should be up to each developper imho

group_imports = "One"
use_field_init_shorthand = true
use_try_shorthand = true
final_newline = true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't find any occurence of this configuration variable in rustfmt. Is this addition intended?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants