4× faster RGB/A to palette conversion - #148
Merged
Merged
Conversation
shssoichiro
approved these changes
Nov 23, 2018
shssoichiro
left a comment
Collaborator
There was a problem hiding this comment.
This looks awesome. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manipulation of palette as separate vec of RGB bytes and tRNS to match was cumbersome. I've changed the internal representation of palette to a vec RGBA colors. Actual chunks are auto-generated on file write.
Fixed-size 4-byte RGBA pixels are much cheaper to use than 128-bit fat pointers of variable-length slices.
With colors being structs I was able to replace duplicate RGB and RGBA reduction functions with one function using generics.
The end result is that RGBA to palette reduction is 4-4.5 times faster.