Don't apply any alpha optimizations if they are disabled - #187
Merged
Conversation
Collaborator
|
Given the discussion around how alpha reduction may not be lossless in some cases, I think it may be better to never enable alpha reduction with a preset, i.e. only enable if the user passes the |
sethdusek
force-pushed
the
master
branch
2 times, most recently
from
August 10, 2019 17:37
bc4e6a4 to
b808239
Compare
shssoichiro
previously approved these changes
Sep 24, 2019
shssoichiro
left a comment
Collaborator
There was a problem hiding this comment.
I'm going to go ahead and change this to disable alpha optimization at all presets, since it's not truly lossless. This means a user will have to explicitly pass the --alpha flag to enable it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #164