Add "max" level alias; various level-related warnings - #224
Merged
Conversation
It's not obvious immediately that these levels don't have any effect on libdeflater and Zopfli, since they don't iterate over zlib-specific fine-tuned options. Hence, show warning so that user knows they're getting "downgraded" to level 3.
RReverser
commented
Apr 20, 2020
shssoichiro
approved these changes
Apr 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Options::from_preset(4)/-o 4as per Is preset 4 deprecated or incorrect? #221. Can be still removed later, but for now at least avoids confusion.Options::max_compressionand-o maxto always refer to best compression as discussed in Is preset 4 deprecated or incorrect? #221.-o 6, but I think it's worth showing a warning now that we have explicitmax_compressionmethod / option.