Add PolygonSeries #2033
Draft
Add PolygonSeries #2033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VisualMelon
commented
Aug 16, 2023
Comment on lines
+94
to
+120
| // DataPoint cur = outline[0]; | ||
| // DataPoint prev; | ||
| // for (int i = 1; i < outline.Length; i++) | ||
| // { | ||
| // prev = cur; | ||
| // cur = outline[i]; | ||
|
|
||
| // if (cur.Equals(prev)) | ||
| // { | ||
| // continue; | ||
| // } | ||
|
|
||
| // var y0 = Math.Min(cur.Y, prev.Y); | ||
| // var y1 = Math.Max(cur.Y, prev.Y); | ||
|
|
||
| // if (y0 > p.Y || y1 <= p.Y) | ||
| // continue; | ||
|
|
||
| // var c = (p.Y - prev.Y) / (cur.Y - prev.Y); | ||
| // var x = prev.Y + c * (cur.X - prev.Y); | ||
|
|
||
| // if (x <= p.X) | ||
| // intersectionCount++; | ||
| // } | ||
|
|
||
| // return intersectionCount % 2 == 0; | ||
| //} |
There was a problem hiding this comment.
No idea where this code came from or if it works for why it's commented out. Probably don't need it at all (tracker is done in screen space).
|
Outstanding questions:
Outstanding problems:
|
Our rendering API does not really support this I think... So this may be hard to implement even if we found a good way to represent this. So I would think we could do without for now.
An outline tracker (that could be enabled as an option) could be nice-to-have, but I wouldn't consider it a must from the start. |
|
Here are my impressions after trying it out.
|
|
Thanks for the feedback: working without a color axis is clearly an overlooked use case. |
Fixed an issue where PolygonSeries was not displayed correctly in ExampleBrowser. Fixes for errors from the IDE
Fix `PolygonItem.ToCode`
Add SADASHIMA as a contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1751 .
Checklist
-> want some interesting/compelling examples
Changes proposed in this pull request:
PolygonSeriesand examples@oxyplot/admins