-
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
BUG: DataFrame index name no longer resets after appending a list of series #44123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jreback
merged 16 commits into
pandas-dev:master
from
robbertjan94:retain_name_appending_list
Nov 5, 2021
Merged
BUG: DataFrame index name no longer resets after appending a list of series #44123
jreback
merged 16 commits into
pandas-dev:master
from
robbertjan94:retain_name_appending_list
Nov 5, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
robbertjan94
commented
Oct 20, 2021
- closes DataFrame index name reset after appending a list of Series #44109
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
Hello @robbertjan94! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-11-03 21:06:57 UTC |
jbrockmendel
approved these changes
Oct 31, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jreback
requested changes
Nov 1, 2021
jreback
approved these changes
Nov 5, 2021
thanks @robbertjan94 very nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.