Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@phofl
Copy link
Member

@phofl phofl commented Dec 1, 2021

cc @lithomas1 I am also on board with deprecating this. I don't think the keyword adds real value

@phofl phofl added Deprecate Functionality to remove in pandas IO CSV read_csv, to_csv labels Dec 1, 2021
- Deprecated casting behavior when setting timezone-aware value(s) into a timezone-aware :class:`Series` or :class:`DataFrame` column when the timezones do not match. Previously this cast to object dtype. In a future version, the values being inserted will be converted to the series or column's existing timezone (:issue:`37605`)
- Deprecated casting behavior when passing an item with mismatched-timezone to :meth:`DatetimeIndex.insert`, :meth:`DatetimeIndex.putmask`, :meth:`DatetimeIndex.where` :meth:`DatetimeIndex.fillna`, :meth:`Series.mask`, :meth:`Series.where`, :meth:`Series.fillna`, :meth:`Series.shift`, :meth:`Series.replace`, :meth:`Series.reindex` (and :class:`DataFrame` column analogues). In the past this has cast to object dtype. In a future version, these will cast the passed item to the index or series's timezone (:issue:`37605`)
- Deprecated the 'errors' keyword argument in :meth:`Series.where`, :meth:`DataFrame.where`, :meth:`Series.mask`, and meth:`DataFrame.mask`; in a future version the argument will be removed (:issue:`44294`)
- Deprecated the ``header`` keyword argument in :func:`read_csv` and :func:`read_table`, in a future version the argument will be removed (:issue:`43396`)
Copy link
Member

@asishm asishm Dec 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't this be prefix (and not header)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

@lithomas1
Copy link
Contributor

Using parser.read_csv_check_warnings should fix the stacklevel issues.

def read_csv_check_warnings(
self, warn_type: type[Warning], warn_msg: str, *args, **kwargs
):
# We need to check the stacklevel here instead of in the tests
# since this is where read_csv is called and where the warning
# should point to.
kwargs = self.update_kwargs(kwargs)
with tm.assert_produces_warning(warn_type, match=warn_msg):
return read_csv(*args, **kwargs)

It would be also nice to add an example to the user guide of how to add a prefix to the names.

@jreback jreback merged commit 8eb0b1b into pandas-dev:master Dec 3, 2021
@jreback
Copy link
Contributor

jreback commented Dec 3, 2021

thanks @phofl

@phofl phofl deleted the 43396 branch December 4, 2021 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Deprecate Functionality to remove in pandas IO CSV read_csv, to_csv

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DEPR: prefix argument in read_csv/read_table

4 participants