TST : Add comprehensive unit tests for tm.shares_memory utility function (GH#55372) #62291
+14
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a start, but there are a ton of cases not covered before we can close #55372 |
jbrockmendel
reviewed
Sep 8, 2025
| @@ -30,3 +30,18 @@ def test_shares_memory_string(): | |||
|
|
|||
| obj = pd.array(["a", "b"], dtype=pd.ArrowDtype(pa.string())) | |||
| assert tm.shares_memory(obj, obj) | |||
|
|
|||
|
|
|||
| # Unit tests for tm.shares_memory (#55372) | |||
There was a problem hiding this comment.
Thanks! I will remove this.
|
I agree that many important cases (like Series, DataFrame, MultiIndex, etc.) are not yet covered due to current implementation limitations. |
|
Edited the OP to reflect that this doesn't close the issue, set the CI to re-run as the failures should be unrelated. ill merge once that comes back green. |
jbrockmendel
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests cover the currently supported cases: Numpy arrays and RangeIndex
Please let me know if my approach or fix needs any improvements . I’m open to feedback and happy to make changes based on suggestions.
Thanks!