[generators] always put configure options at beginning#1517
Merged
Conversation
put all makefile vars (specified via configure) before including the board makefile. e.g. RADIO_CONTROL_PPM_PIN has moved to the board makefile, and this ``` <subsystem name="radio_control" type="ppm"> <configure name="RADIO_CONTROL_PPM_PIN" value="UART1_RX"/> </subsystem> ``` was not working anymore and instead it was necessary to move the configure line outside of the subsystem lines: ``` <subsystem name="radio_control" type="ppm"/> <configure name="RADIO_CONTROL_PPM_PIN" value="UART1_RX"/> ``` This should fix that regression again.
gautierhattenberger
added a commit
that referenced
this pull request
Jan 14, 2016
[generators] always put configure options at beginning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
put all makefile vars (specified via configure) before including the board makefile.
e.g. RADIO_CONTROL_PPM_PIN has moved to the board makefile, and this
was not working anymore and instead it was necessary to move the configure line outside of the subsystem lines:
This should fix that regression again.