[ocaml] print more verbose info on xml loading errors#1570
Merged
Conversation
Contributor
|
Very welcomed, I know a 100(student) reasons why ;) And we could add if XMLerror encountered start with something descriptive to make sure it is a user error that can be fixed. "There is an Error in your XYZ.shortname.XML you can fix. Your problem to fix is details are:" |
Member
Author
|
I don't quite follow... is the message printed with this update not descriptive enough? |
| | Some f -> | ||
| try | ||
| let xml = Xml.parse_file f in | ||
| let xml = ExtXml.parse_file f in |
Member
There was a problem hiding this comment.
not sure this one should be changed, it breaks the try ... catch and the popup message
7ff1ccc to
93b81d0
Compare
Member
Author
|
@gautierhattenberger thanks for the corrections, updated... |
93b81d0 to
96de219
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try to use our own
ExtXml.parse_fileinstead of plainXml.parse_filein most cases to get a better error report if the xml file is invalid.e.g.
instead of only