fix: SafeParseDelegate ignores name parameter on setValue#1199
Open
augustocarmo wants to merge 1 commit intoparse-community:masterfrom
Open
fix: SafeParseDelegate ignores name parameter on setValue#1199augustocarmo wants to merge 1 commit intoparse-community:masterfrom
SafeParseDelegate ignores name parameter on setValue#1199augustocarmo wants to merge 1 commit intoparse-community:masterfrom
Conversation
Thanks for opening this pull request!
|
SafeParseDelegate ignores name parameter on setValue
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1199 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 122 122
Lines 9971 9971
Branches 1345 1345
======================================
Misses 9971 9971 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Pull Request Checklist
Issue Description
When a variable used the
safeAttribute(String)function, thesetValue(from theSafeParseDelegate) was not working properly when its name was different from thenameparam from the delegate because thenameparam was being ignored.Closes: #1200
Approach
Consider the
SafeParseDelegate'snameparam that is passed via constructor as it's done toParseDelegate.