Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(a11y): update logic for determining URLs to test #5705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcoker merged 1 commit into from
Aug 3, 2023
Merged

chore(a11y): update logic for determining URLs to test #5705

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion patternfly-a11y.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,22 @@ const urls = Object.keys(fullscreenRoutes)
return key;
} else {
const path = fullscreenRoutes[key].path
if (path.match(/\/demos\/.*\/html-demos$/g)) {
if (path.match(/\/patterns\/.*\/html-demos$/g)) {
return path.replace(/\/html-demos$/, '');
} else {
if (
Copy link
Contributor

@mcoker mcoker Jul 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add context selector here? BTW - not sure if this is an issue but the demo page shows up first now, maybe that's intentional since the demos are still valid - they would just ideally be built using menu/menu toggle. Since core isn't going to have a context selector component, I don't know if the context selector demos belong there though. Or maybe the nav link needs a "demo" badge, like password strength/generator?

path.includes('/application-launcher/') |
path.includes('/options-menu/') |
path.includes('/dropdown/') |
path.includes('/select/')
) {
return path.replace(/\/html-deprecated$/, '')
} else if (
path.includes('/password-generator/') |
path.includes('/password-strength/')
) {
return path.replace(/\/html-demos$/, '');
}
return path.replace(/\/html$/, '')
}
}
Expand Down